-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding pagination support to the Consumers resource #63
Conversation
Ah, I'm surprised this didn't come up sooner. Looks like you're the only one with more than 100 consumers! Thanks for this PR. Would you mind completing it to also handle pagination for APIs and Plugins resources? |
@PGBI : done for the APIs and Plugins resources, but not yet for '/apis/:api_id/plugins' and '/consumers/:consumer_id/plugins' because it seems more tricky. |
@diwann So I checked out the code to test it locally, and found these issues:
Regarding '/apis/:api_id/plugins' and '/consumers/:consumer_id/plugins', if paginating them is tricky, I guess we can leave them for now. Being able to paginate consumers, apis and plugins will already be a great improvement! |
|
When I browse http://localhost:8080/#/consumers I get this: Then, when clicking on "Go To next page", the browser location is set to http://localhost:8080/#/consumers?offset=undefined&size= and I'm still seing page 1. |
no, I really meant on "http://localhost:8001/consumers", assuming your Kong node is on localhost? |
My bad, didn't read properly your question. I'm getting this:
This is with Kong 0.6.1 |
Ok, fixed. it seems that Kong 0.6.1 didn't had the "offset" parameter. and Happy New Year! |
@diwann Parfait, c'est mergé. Merci pour ta contribution ! |
Useful when you have more than 100 consumers on Kong